add duckOthers option on iOS #745
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmxv
reviewed
Jan 6, 2022
|
@zmxv hey, I was wondering if there is anything I can do to get this PR merged? Tested it, and it worked as expected. |
|
Any change this can be reviewed and merged? |
|
Heads up - we patched this into our repo, this causes a crash on Android. It was due to the number of arguments. A fix we did: Sound.setCategory = function(value, mixWithOthers = false, duckOthers = false) {
if (!IsWindows) {
if(IsAndroid) {
RNSound.setCategory(value, mixWithOthers);
} else {
RNSound.setCategory(value, mixWithOthers, duckOthers);
}
}
}; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added duckOthers option for iOS
also updated the index.d.ts params here for setActive method. which was wrong